A controller of a generator for a vehicle in the invention includes a battery voltage detecting circuit and an output terminal voltage detecting circuit of an AC generator. A value of a detected voltage of the output terminal voltage of the AC generator is set to be higher than a value of a detected voltage of the battery voltage. A diagnosis alarm signal is outputted when the detected voltage of the battery voltage is lower than the set value while the detected voltage of the output terminal is higher than the set value.